replacing %s with f-string #1165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haviv1idan
force-pushed
the
improvment/remove_python_2.x_style
branch
from
d43b7ba to
3d70987
Compare
haviv1idan
force-pushed
the
improvment/remove_python_2.x_style
branch
from
3d70987 to
2b6ca84
Compare
|
I just noticed that I actually started to work on this already, see branch 1159-formatted-strings. This means I'm going to have to close this PR. However, I will go through your changes, maybe you added something that I might have missed. |
dieser-niko
reviewed
Dec 3, 2024
| tid = sys.argv[1] | ||
| else: | ||
| tid = 'spotify:track:4TTV7EcfroSLWzXRY6gLv6' | ||
| tid = sys.argv[1] if len(sys.argv) > 1 else 'spotify:track:4TTV7EcfroSLWzXRY6gLv6' |
There was a problem hiding this comment.
I won't add these changes, it makes the code a bit harder to read, considering these are just examples.
dieser-niko
reviewed
Dec 3, 2024
| else: | ||
| spotipy.Spotify(auth_manager=SpotifyOAuth()).current_user_follow_playlist(args.playlist) | ||
|
|
||
| playlist = args.playlist or '37i9dQZEVXbMDoHDwVN2tF' # default is Spotify Global Top 50 playlist |
There was a problem hiding this comment.
actually needed to use a different playlist because Spotify blocks access to their own playlists now.
dieser-niko
added a commit
that referenced
this pull request
Dec 3, 2024
Merged
dieser-niko
added a commit
that referenced
this pull request
Jan 14, 2025
* use newer string formatters (https://pyformat.info) * fix typo * went through the files again, additions from #1165 are also included * replace .format() with f strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.